Implemented recover_file.#209
Open
jessicayu626 wants to merge 1 commit intodevelopfrom
Open
Conversation
Antzen
reviewed
Nov 27, 2017
| if (!zk->create(delete_item, block_vec, error_code, false)) { | ||
| LOG(INFO) << "[recover_file] pushed create " << delete_item; | ||
| } | ||
| blockDeleted(block_id, dn); |
Contributor
There was a problem hiding this comment.
This looks good to me, but we should double check that this is a valid delete process with some additional unit tests.
| memcpy(&block_data, &block_data_vec[0], sizeof(block_data)); | ||
| uint64_t block_size = block_data.block_size; | ||
|
|
||
| if (size_left < block_size) { |
Contributor
There was a problem hiding this comment.
I don't think this case would ever be executed under our current implementation of file appends, but it's probably good to keep if future implementations would use "reserve blocks" for file mutability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.